On Sun, Sep 04, 2005 at 11:48:08AM -0700, Junio C Hamano wrote: > Fredrik Kuivinen <[EMAIL PROTECTED]> writes: > > > In non-english locales diff(1) do sometimes output "\ No newline at end of > > file" in some other language. Set LC_ALL to C before execing diff to avoid > > this behaviour. > > > > Signed-off-by: Fredrik Kuivinen <[EMAIL PROTECTED]> > > I was thinking about this when I was examining your other patch. > > What else, other than the incomplete line marker (and timestamp > output it uses by default, which we disable by passing explicit > -L flags), are affected by locale in diff output?
After a quick look through the diff source I didn't find anything else. It's quite possible that I haved missed something though. Most of the translated messages are related to error reporting, which I guess might be nice to have in the user specified language. > Especially, if the diff output is more readable for human > consumers (i.e. reviewers) without making it harder to use to > machine consumers (i.e. patch or git-apply) when generated under > a locale that is 'native' to the data, this patch robs from > users the possibility of doing so. > > IOW, in a Swedes-only project that tracks a document in Swedish, > it _might_ be friendlier and more useful to the users if allowed > generating diffs under sv_SE locale, as long as such a diff does > not make the processing by patch and git-apply more difficult > (which your other patch already solved for git-apply). I agree that it's kind of evil to remove the option of generating the output in some other language. Another possibility is to set LC_MESSAGES to C instead. If we go this way the user can override it by setting LC_ALL. The difference is that in most configurations the user has to make an active choice to get the 'native' language output and english will be the default. - Fredrik - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
