On Sun, Jul 08, 2012 at 06:41:39PM -0700, Junio C Hamano wrote: > Alex Riesen <raa.l...@gmail.com> writes: > > > The original (shell coded) version of the git-clone just used mkdir(1) > > to create the working directories. The builtin changed the mode argument > > to mkdir(2) to 0755, which was a bit unfortunate, as there are use > > A much more important reason why this is a good change (I think you > could even say this is a bugfix) is because directories and files in > the working tree are created with entry.c::create_directories() and > entry.c::create_file(), and they do honour umask settings, and the > top-level of the working tree should be handled the same way, no?
Does the mkdir of "rr-cache/*" in rerere.c make the same mistake? The rr-cache root is made with 0777, and the files inside each subdirectory are created with 0666. So it is the only thing preventing users of shared repos from using rerere. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
