On Thursday 26 July 2012 02:46:07 Jonathan Nieder wrote: > Hi, > > Florian Achleitner wrote: > > --- /dev/null > > +++ b/contrib/svn-fe/remote-svn.c > > @@ -0,0 +1,219 @@ > > + > > +#include "cache.h" > > +#include "remote.h" > > +#include "strbuf.h" > > +#include "url.h" > > +#include "exec_cmd.h" > > +#include "run-command.h" > > +#include "svndump.h" > > +#include "argv-array.h" > > + > > +static int debug; > > + > > +static inline void printd(const char *fmt, ...) > > I remember reviewing this before, and mentioning that this could be > replaced with trace_printf() and that would simplify some code and > improve the functionality. I think I also remember giving some other > suggestions, but I don't have it in front of me so I can't be sure > (should have more time this weekend). > > Did you look over that review? Did you have any questions about it, > or was it just full of bad ideas, or something else? > > It's silly and vain of me, but I'm not motivated by the idea of > spending more time looking over this without anything coming of it. > (Rejecting suggestions is fine, but sending feedback when doing so is > important because otherwise reviewers get demotivated.)
Yes, I incorporated your review in the new version, as far as applicable. But I didn't send you an answer on the detailed points. I will send an answer to the previous review .. > > Hope that helps, > Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
