On Thu, Aug 23, 2012 at 10:10:30AM +0200, mhag...@alum.mit.edu wrote: > From: Michael Haggerty <mhag...@alum.mit.edu> > > Once a match has been found at match_pos, the entry is zeroed and no > future attempts will match that entry. So increment match_pos to > avoid checking against the zeroed-out entry during the next iteration.
Good catch. A subtle side effect of this zero-ing (not introduced by your patch, but something I noticed while re-reading the code) is that we implicitly eliminate duplicate entries from the list of remote refs. There shouldn't generally be any duplicates, of course, but I think skipping them is probably sane. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
