Andrew Wong <andrew.k...@gmail.com> writes: > This allows users to edit the todo list while they're in the middle of > an interactive rebase.
I like the idea. > +edit) > + git_sequence_editor "$todo" || > + die_abort "Could not execute editor" > + > + exit > + ;; Indent with space. Please, use tabs (same below). > index 15da926..c394b8d 100755 > --- a/git-rebase.sh > +++ b/git-rebase.sh > @@ -38,6 +38,7 @@ C=! passed to 'git apply' > continue! continue > abort! abort and check out the original branch > skip! skip current patch and continue > +edit! edit the todo list during interactive rebase Just "edit" may be a bit misleading, as we already have the "edit" action inside the todolist. I'd call this --edit-list to avoid ambiguity. This lacks tests, IMHO, as there are many corner-cases (e.g. should we be allowed to --edit-list while the worktree is in conflict?) that would deserve to be at least discussed, and as much as possible automatically tested. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
