2012/9/12 Junio C Hamano <gits...@pobox.com>: > > Interesting, but it bothers me to make it enabled unconditionally. > At least, this shouldn't be enabled under GIT_TEST_OPTS=--valgrind, no? Sorry for the late response and thanks.
No, setting MALLOC_CHECK don't require valgrind and it considered a best QA to have the test suite with it defined always. If the test suite fail with MALLOC_CHECK, well, there is some problem, no ? Some distro do it already in building packages (fedora for example) http://emacs.1067599.n5.nabble.com/please-set-both-MALLOC-PERTURB-and-MALLOC-CHECK-envvars-td150144.html At @rpm5.org we do the same for popt, for example, from years http://rpm5.org/community/rpm-devel/4156.html > > By the way, "export VAR=VAL" all on the same line, even though it is > in POSIX.1, is reported to be unsupported by some shells people care > about, and needs to be corrected to "VAR=VAL" and "export VAR" as > separate commands. I think we saw a patch to fix an instance or two > that snuck in recently. Yes, right, my bad. I will reroll. Thank you -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
