Adrian Johnson <ajohn...@redneon.com> writes: >> I do not seem to find anything interesting after @@, which means >> that xfuncname is not tested at all even though the log message >> claims the patch adds some. > > I probably misunderstood how the tests work. I thought t4034 tested > wordRegex while t4018 is for xfuncname. I based the Ada tests on the > Pascal tests but changed the operators to Ada operators. I'm not really > sure what else the test needs.
The per-language for-loop you added ada to in t4018 is only to make sure there is no regexp syntax error in the built-in xfuncname, and does not check if the patterns make sense for the language at all. You could add test vectors to check if the built-in xfuncname catches beginning of functions in Ada correctly if you wanted to, but I think observing what appears on @@ lines in t4034 test vector would be a sufficient test. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
