Paul Mackerras <pau...@samba.org> wrote: > On Wed, Sep 19, 2012 at 08:17:27PM +0200, Stefan Haller wrote: > > Here's one way how to address your concern. When pressing the search button > > it will highlight the file that contains the current search hit; if you then > > scroll from there though, the normal mechanism kicks in again and might > > highlight the previous file. The same happens now if you select the last > > file > > in the list, but it's diff is smaller than a screenful. In the previous > > patch versions it would select a different file than you clicked on, which > > is probably also confusing. > > > > Is this what you had in mind? > > Yes, it is, and I applied your patch. I wonder though if it might > work better to highlight all the files that are visible?
Interesting idea. I tried it, but I don't like it much, it just looks and feels so odd. I can send a patch if you're interested in trying it yourself. But personally, I really only need the synchronization feature in the case where a file's diff is longer than fits on a screen; as long as a file header is visible on the left side, it's prominent enough that I don't need more guidance. -Stefan -- Stefan Haller Berlin, Germany http://www.haller-berlin.de/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
