Am 09.10.2012 08:46, schrieb Shawn Pearce: > On Mon, Oct 8, 2012 at 8:05 AM, Johannes Sixt <j...@kdbg.org> wrote: >> Am 05.10.2012 18:57, schrieb Shawn Pearce: >>> Smart HTTP is not bidirectional. The client can't cut off the server. >> >> Smart HTTP does not need it: you already posted a better solution (I'm >> refering to "&v=2"). > > Yes but then it diverges even further from the native bidirectional protocol.
I won't argue here because I know next to nothing about Smart HTTP. But it sounds like you either have compatibility, but a diverging protocol or at least implementation, or no compatibility. >> +static int client_spoke(void) >> +{ >> + struct pollfd pfd; >> + pfd.fd = 0; >> + pfd.events = POLLIN; >> + return poll(&pfd, 1, 0) > 0 && >> + (pfd.revents & (POLLIN|POLLHUP)); > > Except doing this in Java is harder on an arbitrary InputStream type. > I guess we really only care about basic TCP, in which case we can use > NIO to implement an emulation of poll, and SSH, where MINA SSHD > probably doesn't provide a way to see if the client has given us data > without blocking. That makes supporting v2 really hard in e.g. Gerrit > Code Review. You could argue that its improper to attempt to implement > a network protocol in a language whose standard libraries have gone > out of their way to prevent you from polling to see if data is > immediately available, but I prefer to ignore such arguments. Can't you read the inbound stream in a second thread while the first thread writes the advertisements to the outbound stream? Then you don't even need to poll; you can just read the 4-byte length header, stash it away and set a flag. The implementation of client_spoke() would only amount to check that flag. > As it turns out we don't really have this problem with git://. Clients > can bury a v2 request in the extended headers where the host line > appears today. I tried, but it seems that todays git-daemons are too strict and accept only \0host=foo\0, nothing else :-( -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html