> On 10 Aug 2016, at 15:15, Jeff King <p...@peff.net> wrote: > > On Wed, Aug 10, 2016 at 03:03:59PM +0200, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider <larsxschnei...@gmail.com> >> >> format_packet() dies if the caller wants to format a packet larger than >> LARGE_PACKET_MAX. Certain callers might prefer an error response instead. > > I am not sure I agree here. Certainly I see the usefulness of gently > handling a failure to write(). But if you are passing in too-large > buffers, isn't that a bug in the program? > > How would you recover, except by splitting up the content? That might > not be possible depending on how you are using the pkt-lines. And even > if it is, wouldn't it be simpler to split it up before sending it to > format_packet()?
Good argument. I agree - this patch should be dropped. Thanks, Lars -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
