Michael J Gruber <g...@drmicha.warpmail.net> writes: >> grep.c:451:16: warning: comparison of unsigned enum expression < 0 is >> always false [-Wtautological-compare] >> if (p->field < 0 || GREP_HEADER_FIELD_MAX <= p->field) >> ~~~~~~~~ ^ ~ >> 1 warning generated. > > Right, that enum type starts at 0. Junio, you last touched this area. > Can we just dump the first comparison or did you have something else in > mind?
I think it was a leftover from the very first implementation that defensively said "this has to be one of these known ones", and tried to bound it from both sides of the range, regaredless of the actual type of the field (these GREP_HEADER_WHAT things may have been simple integers with #define'd values). Dropping the "negative" comparison is perfectly fine. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
