W dniu 29.08.2016 o 10:05, Johannes Schindelin pisze: > The subcommands are used exactly once, at the very beginning of > sequencer_pick_revisions(), to determine what to do. This is an > unnecessary level of indirection: we can simply call the correct > function to begin with. So let's do that.
Looks good. Parsing is moved from parse_args(), now unnecessary, to the new run_sequencer(). Which also picked up dispatch from sequencer_pick_revisions() - that sometimes didn't pick revisions :-o. "All problems in computer science can be solved by another level of indirection, except of course for the problem of too many indirections." -- David John Wheeler > > While at it, ensure that the subcommands return an error code so that > they do not have to die() all over the place (bad practice for library > functions...). This perhaps should be moved to a separate patch, but I guess there is a reason behind "while at it". Also subcommand functions no longer are local to sequencer.c > > Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> > --- > builtin/revert.c | 36 ++++++++++++++++-------------------- > sequencer.c | 35 +++++++++++------------------------ > sequencer.h | 13 ++++--------- > 3 files changed, 31 insertions(+), 53 deletions(-) Nice size reduction.
