On Wed, Sep 07, 2016 at 04:06:42PM -0400, Jeff King wrote: > +test_expect_success 'remote-http complains cleanly about malformed urls' ' > + # do not actually issue "list" or other commands, as we do not > + # want to rely on what curl would actually do with such a broken > + # URL. This is just about making sure we do not segfault during > + # initialization. > + test_must_fail git remote-http http::/example.com/repo.git > +'
Actually, I guess remote-http actually sees just "/example.com/repo.git" for the case we're discussing. It segfaults with either input without this patch, and works with it, though. (I didn't test "git clone" directly because it hides the segfault made by the remote helper, so we cannot tell the difference between a segfault and "this URL is broken"). -Peff
