[+cc authors of b1c8a11, which regressed this case; I'll quote liberally
to give context]
On Mon, Oct 10, 2016 at 05:48:56PM -0400, Jeff King wrote:
> I can't reproduce the problem with this simple setup:
>
> git init
> echo content >file && git add file
> git commit -F- <<-\EOF
> the subject
>
> the body
>
> Cc: Stable <[email protected]> [4.8+]
> EOF
>
> If I then run:
>
> git send-email -1 [email protected] --dry-run
>
> I get:
>
> /tmp/MH8SfHOjCv/0001-the-subject.patch
> (mbox) Adding cc: Jeff King <[email protected]> from line 'From: Jeff King
> <[email protected]>'
> (body) Adding cc: Stable <[email protected]> [4.8+] from line 'Cc:
> Stable <[email protected]> [4.8+]'
> Dry-OK. Log says:
> Sendmail: /usr/sbin/sendmail -i [email protected] [email protected]
> From: Jeff King <[email protected]>
> To: [email protected]
> Cc: "Stable [4.8+]" <[email protected]>
> Subject: [PATCH] the subject
> Date: Mon, 10 Oct 2016 17:44:25 -0400
> Message-Id: <[email protected]>
> X-Mailer: git-send-email 2.10.1.527.g93d4615
>
> Result: OK
>
> So it looks like it parsed the address, and shifted the "4.8+" bit into
> the name, which seems reasonable. Does my example behave differently on
> your system? If not, can you see what's different between your
> real-world case and the example?
>
> It might also be related to which perl modules are available. We'll use
> Mail::Address if you have it, but some fallback routines if you don't.
> They may behave differently.
>
> Alternatively, if this used to work, you might try bisecting it.
Ah, it is Mail::Address. It gets this case right, but if I uninstall it,
then the cc becomes:
Cc: Stable <[email protected][4.8+]>
that you saw, which is broken. Older versions of git, even without
Mail::Address, got this right. The breakage bisects to b1c8a11
(send-email: allow multiple emails using --cc, --to and --bcc,
2015-06-30) from v2.6.0, but I didn't dig deeper into the cause.
-Peff
