We are careful in test_done to handle a results directory with a space in it, but the "--tee" code path does not. Doing:
export TEST_OUTPUT_DIRECTORY='/tmp/path with spaces' ./t000-init.sh --tee results in errors. Let's consistently double-quote our path variables so that this works. Signed-off-by: Jeff King <[email protected]> --- I imagine nobody cares much about this, but I just happened to notice it while writing the rest of the patches (and it's obviously quite easy to fix). t/test-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/test-lib.sh b/t/test-lib.sh index 11562bde10..33cbbb7806 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -58,8 +58,8 @@ done,*) mkdir -p "$TEST_OUTPUT_DIRECTORY/test-results" BASE="$TEST_OUTPUT_DIRECTORY/test-results/$(basename "$0" .sh)" (GIT_TEST_TEE_STARTED=done ${SHELL_PATH} "$0" "$@" 2>&1; - echo $? > $BASE.exit) | tee $BASE.out - test "$(cat $BASE.exit)" = 0 + echo $? >"$BASE.exit") | tee "$BASE.out" + test "$(cat "$BASE.exit")" = 0 exit ;; esac -- 2.10.1.776.ge0e381e
