> On 25 Oct 2016, at 20:16, Junio C Hamano <gits...@pobox.com> wrote: > > Here is to make sure everybody is on the same page regarding the > series. The patches are adjusted for comments from Eric and Dscho.
Thank you, Junio! Your v3 looks good to me and I compiled and tested it on Windows. There is one catch though: I ran the tests multiple times on Windows and I noticed that the following test seems flaky: t0021 `required process filter should be used only for "clean" operation only' This flaky-ness was not introduced by your v3. I was able to reproduce the same behavior for v2. I wonder why I did not noticed that before. The only difference to before is that my Windows machines does some heavy CPU/network task in the background now (I can't/don't want to stop that ATM). Here is the relevant part of the log: ++ rm -f rot13-filter.log ++ git checkout --quiet --no-progress . + test_eval_ret_=255 + want_trace + test t = t + test t = t + set +x error: last command exited with $?=255 Looks like Git exists with 255. Any idea why that might happen? @Dscho/Johannes: Can you try this on your Windows machines? Thanks, Lars
