On 11/04, Jeff King wrote: > On Fri, Nov 04, 2016 at 02:35:57PM -0700, Stefan Beller wrote: > > > On Fri, Nov 4, 2016 at 1:58 PM, Brandon Williams <bmw...@google.com> wrote: > > > On 11/04, Brandon Williams wrote: > > >> Signed-off-by: Brandon Williams <bmw...@google.com> > > > > > > Is there an acceptable way to give credit to Jeff for helping with this > > > patch? > > > > What about: > > Helped-by: Jeff King <p...@peff.net> > > That, or often I would write: > > Based on a patch by Jeff King <p...@peff.net> > > in the commit message. Basically anything is OK _except_ forging > signed-off-by, because it has a very specific meaning. So let me also > say that I am happy to give my: > > Signed-off-by: Jeff King <p...@peff.net> > > to the original (which you should add in, to make clear that the > copyright issues are OK). > > In some cases it makes sense to just roll somebody's patch into your > series, and then build on top. I'm fine with it all going into a single > patch here. > > -Peff
Oh if it would be more clear I can easily break it up into two patches. -- Brandon Williams
