Similar to "mv a b/", which is actually "mv a b/a", we extract basename
of source worktree and create a directory of the same name at
destination if dst path is a directory.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclo...@gmail.com>
---
 builtin/worktree.c | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/builtin/worktree.c b/builtin/worktree.c
index c0d4a73..307019c 100644
--- a/builtin/worktree.c
+++ b/builtin/worktree.c
@@ -539,7 +539,13 @@ static int move_worktree(int ac, const char **av, const 
char *prefix)
        strbuf_addstr(&dst, prefix_filename(prefix,
                                            strlen(prefix),
                                            av[1]));
-       if (file_exists(dst.buf))
+       if (is_directory(dst.buf))
+               /*
+                * keep going, dst will be appended after we get the
+                * source's absolute path
+                */
+               ;
+       else if (file_exists(dst.buf))
                die(_("target '%s' already exists"), av[1]);
 
        worktrees = get_worktrees();
@@ -556,6 +562,17 @@ static int move_worktree(int ac, const char **av, const 
char *prefix)
        if (validate_worktree(wt, 0))
                return -1;
 
+       if (is_directory(dst.buf)) {
+               const char *sep = find_last_dir_sep(wt->path);
+
+               if (!sep)
+                       die(_("could not figure out destination name from 
'%s'"),
+                           wt->path);
+               strbuf_addstr(&dst, sep);
+               if (file_exists(dst.buf))
+                       die(_("target '%s' already exists"), dst.buf);
+       }
+
        /*
         * First try. Atomically move, and probably cheaper, if both
         * source and target are on the same file system.
-- 
2.8.2.524.g6ff3d78

Reply via email to