Hi,

On 10/27/2016 06:59 PM, Junio C Hamano wrote:
> Does any of you (and others on the list) have time and inclination
> to review this series?

Me, currently. ;)
Besides the things I'm mentioning in respective patch e-mails, I wonder
why several bisect--helper commands are prefixed by "bisect"; I'm
talking about:

        git bisect--helper --bisect-clean-state
        git bisect--helper --bisect-reset
        git bisect--helper --bisect-write
        git bisect--helper --bisect-check-and-set-terms
        git bisect--helper --bisect-next-check
        git bisect--helper --bisect-terms
        git bisect--helper --bisect-start
        etc.

instead of

        git bisect--helper --clean-state
        git bisect--helper --reset
        git bisect--helper --write
        git bisect--helper --check-and-set-terms
        git bisect--helper --next-check
        git bisect--helper --terms
        git bisect--helper --start
        etc.

Well, I know *why* they have these names: because the shell function
names are simply reused. But I don't know why these prefixes are kept in
the bisect--helper command options. On the other hand, these command
names are not exposed to the user and may hence not be that important.(?)

~Stephan

Reply via email to