On Tue, Nov 15, 2016 at 02:28:31PM -0800, Stefan Beller wrote: > On Tue, Nov 15, 2016 at 6:56 AM, Heiko Voigt <hvo...@hvoigt.net> wrote: > > > -static int submodule_needs_pushing(const char *path, const unsigned char > > sha1[20]) > > +static int check_has_commit(const unsigned char sha1[20], void *data) > > { > > - if (add_submodule_odb(path) || !lookup_commit_reference(sha1)) > > + int *has_commit = (int *) data; > > nit: just as prior patches ;) void* can be cast implicitly.
Even though its just a nit: Will remove all the void casts. :) Cheers Heiko