On Wed, Dec 7, 2016 at 4:39 PM, <vi0...@gmail.com> wrote: > > Previously test contained errorneous > test_must_fail, which was masked by > missing &&.
I wonder if we could make either the test_must_fail intelligent to detect such a broken && call chain or the test_expect_success macro to see for those broken chains. Patch looks good to me except one very minor nit. :) > +test_expect_success 'nested submodule alternate in works and is actually > used' ' > + test_when_finished "rm -rf supersuper-clone" && > + git clone --recursive --reference supersuper supersuper > supersuper-clone && > + ( > + cd supersuper-clone && > + # test superproject has alternates setup correctly > + test_alternate_is_used .git/objects/info/alternates . && > + # immediate submodule has alternate: > + test_alternate_is_used > .git/modules/subwithsub/objects/info/alternates subwithsub here is a && missing ;)
