Hi Hannes, On Thu, 22 Dec 2016, Johannes Sixt wrote:
> Am 22.12.2016 um 22:37 schrieb Johannes Schindelin: > > > Would you have a suggestion how to rephrase the comment to make it > > less confusing? > > Perhaps > > * This might close the cached console handle. > * We must cache the live duplicate instead. > > Then update the cache before the dup2, because at this time all 3 of console, > handle, and duplicate are live and cannot be recycled: > > if (console == handle) > console = duplicate; > dup2(new_fd, fd); Good point. I reworded the comment slightly differently (see the interdiff in v3 0/3), hope you don't mind. Ciao, Dscho
