On Thu, Dec 29, 2016 at 04:37:30PM -0800, Stefan Beller wrote: > > + mkdir lsremote-root && > > + ( > > + GIT_CEILING_DIRECTORIES=$(pwd) && > > + export GIT_CEILING_DIRECTORIES && > > + cd lsremote-root && > > + git ls-remote "$HTTPD_URL/smart/repo.git" >../actual > > + ) && > > We could avoid the subshell via > > GIT_CEILING_DIRECTORIES=$(pwd) \ > git -C lsremote-root lsremote ... >actual > > Not sure if it is worth to trade off a block of code (and an extra shell > at run time) for an overly long line. > > The rest looks good to me.
I mentioned elsewhere that we now have a "nongit" function to do this as a one-liner. It might be worth applying your optimization to that function, so it would take effect in may places. -Peff
