Re: [PATCH] submodule.c: use GIT_DIR_ENVIRONMENT consistently

[René Scharfe]

Am 30.12.2016 um 01:47 schrieb Stefan Beller:
diff --git a/submodule.c b/submodule.c
index ece17315d6..973b9f3f96 100644
--- a/submodule.c
+++ b/submodule.c
@@ -1333,5 +1333,6 @@ void prepare_submodule_repo_env(struct argv_array *out)
                if (strcmp(*var, CONFIG_DATA_ENVIRONMENT))
                        argv_array_push(out, *var);
        }
-       argv_array_push(out, "GIT_DIR=.git");
+       argv_array_push(out, "%s=%s", GIT_DIR_ENVIRONMENT,
+               DEFAULT_GIT_DIR_ENVIRONMENT);

argv_array_pushf (with added "f") instead?

And indent continued lines to align them with the left parenthesis, like 
this:

        fn(arg1,
           arg2);

 }