Pat Pannuto <pat.pann...@gmail.com> writes: > You may still want the 1/2 patch in this series, just to make things > internally consistent with "-w" vs "use warnings;" inside git's perl > scripts.
I do not think so. 1/2 is justified as a prerequisite of 2/2 and needs a different log message, so cannot be used as is. I vaguely recall hearing arguments for and against the choice between "#!path-to-perl -w" vs "use warnings;" but do not recall the details to have a strong opinion either way, so we might even end up wanting to be "internally consistent" by going the other way. Please prepare a standalone patch with an update message to convince people why "use warnings;" is more preferable than "#!path-to-perl -w" and explaining that we are making things consistently use the more preferable form, if you want to go in that direction. Thanks.
