On Wed, Jan 11, 2017 at 2:21 AM, Junio C Hamano <gits...@pobox.com> wrote: > Karthik Nayak <karthik....@gmail.com> writes: > >> index 81db67d74..08be8462c 100644 >> --- a/Documentation/git-for-each-ref.txt >> +++ b/Documentation/git-for-each-ref.txt >> @@ -95,13 +95,17 @@ refname:: >> The name of the ref (the part after $GIT_DIR/). >> For a non-ambiguous short name of the ref append `:short`. >> The option core.warnAmbiguousRefs is used to select the strict >> + abbreviation mode. If `lstrip=<N>` is appended, strips `<N>` >> + slash-separated path components from the front of the refname >> + (e.g., `%(refname:lstrip=2)` turns `refs/tags/foo` into `foo` and >> + `%(refname:rstrip=2)` turns `refs/tags/foo` into `refs`). > > I hiccupped while reading this, as the (e.g.) example talks about rstrip > that is not mentioned in the main text that is enhanced by the > example. > > If `lstrip=<N>` (`rstrip=<N>`) is appended, strips `<N>` > slash-separated path components from the front (tail) of the > refname (e.g. `%(refname:lstrip=2)` ... > > perhaps? > >> + if `<N>` is a negative number, then only `<N>` path components >> + are left behind. > > Begin the sentence with cap? I'd rephrase it a bit while at it if I > were doing this: > > If `<N>` is a negative number, strip as many path components > as necessary from the specified end to leave `-<N>` path > components. > > Other than the above, looks very good to me. > > Thanks.
I like how you rephrased it. So apart form this and the other change suggested by you and Jacob, nothing to be added. Should I re-roll? -- Regards, Karthik Nayak
