On Tue, Oct 30, 2012 at 2:35 PM, Felipe Contreras <felipe.contre...@gmail.com> wrote: > On Tue, Oct 30, 2012 at 10:17 PM, Sverre Rabbelier <srabbel...@gmail.com> > wrote: >> On Tue, Oct 30, 2012 at 11:47 AM, Felipe Contreras >> <felipe.contre...@gmail.com> wrote: >>> Why would it? We are not changing the way objects are exported, the >>> only difference is what happens at the end >>> (handle_tags_and_duplicates()). >> >> Because the marking is per-commit, not per-ref, right? > > Oh, you meant using marks?
No, I meant the 'SHOWN' flag, doesn't it get added per commit, not per ref? That is, commit->object.flags & SHOWN refers to the object underlying the ref. So I suspect this scenario doesn't pass the tests: git init && echo first > content && git add content && git commit -m "first" && git branch first && echo two > content && git commit -m "second" && git branch second && git fast-export first > actual && test_cmp actual expected_first && git fast-export second > actual && test_cmp actual expected_second With expected_first being something like: <fast-export stream with the first commit> <reset command to set first to the right commit> And expected_second being something like <fast export stream with the first and second command> <reset command to set first and second to their respective branches> -- Cheers, Sverre Rabbelier -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
