On Thu, Jan 19, 2017 at 1:06 PM, Junio C Hamano <gits...@pobox.com> wrote: > Jacob Keller <jacob.e.kel...@intel.com> writes: > >> From: Jacob Keller <jacob.kel...@gmail.com> >> >> Teach git name-rev to take multiple --refs stored as a string list of >> patterns. The list of patterns will be matched inclusively, and each ref >> only needs to match one pattern to be included. A ref will only be >> excluded if it does not match any of the given patterns. Additionally, >> if any of the patterns would allow abbreviation, then we will abbreviate >> the ref, even if another pattern is more strict and would not have >> allowed abbreviation on its own. >> >> Add tests and documentation for this change. The tests expected output >> is dynamically generated, but this is in order to avoid hard-coding >> a commit object id in the test results (as the expected output is to >> simply leave the commit object unnamed). > > Makes sense. > > I do not see anything that requires "... generated, but" there, > though, as if it is a bad thing to do to prepare expected output > dynamically. I'd just reword "generated. This is..." to make it > neutral.
To clarify my earlier comment, I think the SQUASH?? you queued looks great. Thanks, Jake
