Siddharth Kannan <[email protected]> writes: > Hello Matthieu, > > On 8 February 2017 at 20:10, Matthieu Moy <[email protected]> > wrote: >> In a previous discussion, I made an analogy with "cd -" (which is the >> source of inspiration of this shorthand AFAIK): "-" did not magically >> become "the last visited directory" for all Unix commands, just for >> "cd". And in this case, I'm happy with it. For example, I never need >> "mkdir -", and I'm happy I can't "rm -fr -" by mistake. >> >> So, it's debatable whether it's a good thing to have all commands >> support "-". For example, forcing users to explicitly type "git branch >> -d @{1}" and not providing them with a shortcut might be a good thing. > > builtin/branch.c does not call setup_revisions and remains unaffected > by this patch :)
Right, I forgot this: in some place we need any revspec, but "branch -d" needs a branch name explicitly. > [...] > As you might notice, in this list, most commands are not of the `rm` variety, > i.e. something that would delete stuff. OK, I think I'm convinced. Keep the arguments in mind when polishing the commit message. -- Matthieu Moy http://www-verimag.imag.fr/~moy/
