On Wed, Feb 15, 2017 at 12:23:52AM +0530, Pranit Bauva wrote: > Did you purposely miss the one in line number 278 of > builtin/show-branch.c because I think you only touched up the parts > which were related to "refs/" but didn't explicitly mention it in the > commit message? > > if (starts_with(pretty_str, "[PATCH] ")) > pretty_str += 8;
Not purposely. I was just fixing up the bits that I had noticed in the earlier patches. > diff --git a/builtin/show-branch.c b/builtin/show-branch.c > index c03d3ec7c..19756595d 100644 > --- a/builtin/show-branch.c > +++ b/builtin/show-branch.c > @@ -275,8 +275,7 @@ static void show_one_commit(struct commit *commit, int > no_name) > pp_commit_easy(CMIT_FMT_ONELINE, commit, &pretty); > pretty_str = pretty.buf; > } > - if (starts_with(pretty_str, "[PATCH] ")) > - pretty_str += 8; > + skip_prefix(pretty_str, "[PATCH] ", &pretty_str); Yeah, I agree this the same type of fix and is worth including. Thanks! -Peff
