On Wed, Feb 15, 2017 at 10:10 AM, Junio C Hamano <gits...@pobox.com> wrote: > Stefan Beller <sbel...@google.com> writes: > >> We need the gentle version in a later patch. As we have just one caller, >> migrate the caller. > > Ordinarily, we keep the original helper implemented as a thin > wrapper that passes NULL as retun_error_code, which causes it to > die() on error for existing callers. But because we only have one > caller (and topics in-flight do not add new ones), we do not bother > with that.
Right. > > The reasoning makes sense, at least to me. > > We may want to add a comment about the behaviour upon error for the > helper function? I see resolve_gitdir_gently() does not do so and > the readers have to follow the callflow down to read_gitfile_gently() > which does have the comment, so perhaps we are OK without any. > > Looks good to me. Will do in a reroll. Thanks, Stefan
