On Thu, Feb 16, 2017 at 09:59:25AM -0800, Junio C Hamano wrote: > Johan Hovold <jo...@kernel.org> writes: > > > I recently noticed that after an upgrade, git-send-email (2.10.2) > > started aborting when trying to send patches that had a linux-kernel > > stable-tag in its body. For example, > > > > Cc: <sta...@vger.kernel.org> # 4.4 > > > > was now parsed as > > > > "sta...@vger.kernel.org#4.4" > > ... > > It sounds like a fallout of this: > > > https://public-inbox.org/git/41164484-309b-bfff-ddbb-55153495d...@lwfinger.net/#t > > > and any change to "fix" you may break the other person.
Yes, that's the thread I was referring to as well, and the reported breakage is the same even if the reporter used a non-standard stable-tag format (e.g. a "[4.8+]" suffix). What I'm wondering is whether the alternative fix proposed in that thread, to revert to the old behaviour of discarding trailing comments, should be considered instead of what was implemented. > > Can we please revert to the old behaviour of simply discarding such > > comments (from body-CC:s) or at least make it configurable through a > > configuration option? > > If I recall the old thread correctly, it was reported that using > Mail::Address without forcing git-send-email fall back to its own > non-parsing-but-paste-address-looking-things-together code would > solve it, so can the "make it configurable" be just "install > Mail::Address"? I believe git-send-email's parser was changed to mimic Mail::Address, and installing it does not seem to change the behaviour of including any trailing comments in the name. Thanks, Johan
