Junio C Hamano <gits...@pobox.com> writes: > Jeff King <p...@peff.net> writes: > >>> diff --git a/refs.h b/refs.h >>> index 9fbff90e7..81627a63d 100644 >>> --- a/refs.h >>> +++ b/refs.h >>> @@ -277,7 +277,7 @@ int reflog_exists(const char *refname); >>> * be NULL_SHA1. flags is passed through to ref_transaction_delete(). >>> */ >>> int delete_ref(const char *refname, const unsigned char *old_sha1, >>> - unsigned int flags); >>> + unsigned int flags, const char *msg); >> >> Should the "msg" argument go at the beginning, to match update_ref()? > > Probably. rename/create have the message at the end but their > parameters are very different from update/delete. The parameters > update and delete take are not identical, but we can view them as a > lot more similar than the other two. So I think it makes sense for > delete to try matching update, even though trying to make all four > the same may proabably be pointless.
I put "msg" after "flags" because that's where it occurs in ref_transaction_delete(), but matching update_ref() makes sense. -- Kyle
