On 02/18/2017 02:32 PM, Nguyễn Thái Ngọc Duy wrote: > get_ref_store() will soon be renamed to get_submodule_ref_store(). > Together with future get_worktree_ref_store(), the three functions > provide an appropriate ref store for different operation modes. New APIs > will be added to operate directly on ref stores.
I see where you're going with this, but as of the end of this patch series, there is still nothing that a caller outside of the refs module can do with a `struct ref_store *`. This means that it would be enough to put this declaration (and that of `get_submodule_ref_store()`, added in a later patch) in refs/refs-internal.h for now. If you want to move the declarations straight to `refs.h` now to avoid code churn in some later patch series, then please mention that fact in the commit message. Michael
