René Scharfe <l....@web.de> writes: > Am 01.03.2017 um 23:35 schrieb Junio C Hamano: >> * rs/log-email-subject (2017-03-01) 2 commits >> - pretty: use fmt_output_email_subject() >> - log-tree: factor out fmt_output_email_subject() >> >> Code clean-up. >> >> Will merge to 'next'. > > Could you please squash this in? We only use a single context (as > opposed to an array), so it doesn't have to be especially compact, > and using a bitfield slows down half of the tests in p4000 by 3% > for me.
I thought I saw the keyword "bitfield" to the solution for that 3% somewhere in the thread and forgot when I updated the "What's cooking" report. Will do. Thanks for being careful. > > --- > commit.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/commit.h b/commit.h > index 459daef94a..528272ac9b 100644 > --- a/commit.h > +++ b/commit.h > @@ -154,7 +154,7 @@ struct pretty_print_context { > int preserve_subject; > struct date_mode date_mode; > unsigned date_mode_explicit:1; > - unsigned print_email_subject:1; > + int print_email_subject; > int expand_tabs_in_log; > int need_8bit_cte; > char *notes_message;