On Thu, Mar 09, 2017 at 12:51:06PM +0100, Johannes Schindelin wrote: > On Wed, 8 Mar 2017, Junio C Hamano wrote: > > > Jeff King <p...@peff.net> writes: > > > > >> Or are you discussing a more general issue, iow, anything that can > > >> work without repository (i.e. those who do _gently version of the > > >> setup and act on *nongit_ok) should pretend as if there were no > > >> (broken) repository and take the "no we are not in a repository" > > >> codepath? > > > > > > Yes, exactly. It would have been less confusing if I picked something > > > that passed nongit_ok. Like hash-object: > > ... or like testing the early config directly?
I was trying to demonstrate that the problem existed already without your patch series. > -- snipsnap -- > From: Johannes Schindelin <johannes.schinde...@gmx.de> > Subject: [PATCH] t1309: document cases where we would want early config not to > die() > > Jeff King came up with a couple examples that demonstrate how the new > read_early_config() that looks harder for the current .git/ directory > could die() in an undesirable way. > > Let's add those cases to the test script, to document what we would like > to happen when early config encounters problems. Yep, these all look fine. -Peff
