> And one final note. I notice that we return NULL if the user has no > HOME. But I'm not sure most callers are prepared to handle this. E.g., > if you have no ident set and no HOME, then we will pass NULL to lstat(). > On Linux at least that just gets you EFAULT, but I wouldn't be surprised > if it's a segfault on other systems (probably at least Windows, where we > have an lstat wrapper that calls strlen on the filename).
Right now we check the return value from these two functions and if it is NULL we instead use some other configuration location. That said I agree that this could lead to unexpected behavior in some scenarios. Devin
