On Thu, Mar 16, 2017 at 4:24 PM, Stefan Beller <sbel...@google.com> wrote: > On Thu, Mar 16, 2017 at 3:29 PM, Brandon Williams <bmw...@google.com> wrote: >> Sync does some work determining what URLs should be used for a submodule >> but then throws this work away if the submodule isn't active. Instead >> perform the activity check earlier and skip inactive submodule in order >> to avoid doing unnecessary work. >> >> Signed-off-by: Brandon Williams <bmw...@google.com> >> --- > >> + # skip inactive submodules >> + if ! git config "submodule.$name.url" >/dev/null 2>/dev/null > > As a stand alone patch, this would look good to me. > But with the goal of this patch series in mind (which is to add > more options to enable a submodules "active" state), this > should rather be "submodule--helper is-active" here? >
I spoke too early. this happens in the next patch. ok, thanks! Stefan
