On Thu, Mar 16, 2017 at 10:24:32PM -0700, Junio C Hamano wrote: > Jeff King <p...@peff.net> writes: > > > On Thu, Mar 16, 2017 at 03:43:13PM -0700, Junio C Hamano wrote: > > > >> Jeff King <p...@peff.net> writes: > >> > >> > +ifdef USE_SHA1DC > >> > + LIB_OBJS += sha1dc/sha1.o > >> > + LIB_OBJS += sha1dc/ubc_check.o > >> > + BASIC_CFLAGS += -DSHA1_SHA1DC > >> > >> The name of this CPP symbol is one difference between this and > >> Linus's version. Wouldn't "-DSHA1_DC" make more sense? > > > > I'm fine with either. Somehow SHA1_DC felt too short, but it doesn't > > really matter in practice. > > I'm fine with either, too. It was just double SHA1 felt a bit > strange, when the naming convention was SHA1_ followed by the > characteristic attribute of the implementation (e.g. came from > Mozilla, etc.) and I thought "Detecting Collision" was the notable > characteristic of this one.
Yeah, I thought "DC" by itself was funny, but I guess "BLK" by itself is no less funny. I'm happy to re-roll it if you prefer the other. -Peff
