On Wed, Mar 29, 2017 at 06:42:38PM -0700, Stefan Beller wrote: > Ever wondered why column.ui applies the untracked files in git-status, > but not for the help text comment in git-commit? Nobody wrote the code! > > This is marked as WIP, as it barely demonstrates how the code may look > like. No tests, no documentation.
I'm confused about what this patch is trying to do. Is it just to turn on column.status support for the template shown by git-commit? Or is it columnizing more than the untracked files list? If the former, why isn't just setting s.colopts enough? I guess because we write into a strbuf? If the latter, then isn't that a separate logical patch from "should commit use columns"? I don't have an opinion on the whole thing myself, as I do not use columns nor really know how they are supposed to work. You found my 4d2292e9a9, but I was explicitly trying _not_ to get involved in any behavior changes there due to my cluelessness. :) I think Duy, who wrote all of the column code, is a better person to cc. -Peff
