On 11.11.2012, at 14:59, Felipe Contreras wrote:

> People seeking for reference would find it useful.

Hm, I don't understand this commit message. Probably means I am just too dumb, 
but since I am one of those people who would likely be seeking for reference, I 
would really appreciate if it could clarified. Like, for example, I don't see 
how the patch below makes anything "clear", it just seems to change the 
"import" command of git-remote-testgit to make use of the 'done' feature?

Perhaps the idea of the patch is to make use of the "done" feature so that 
remote-testgit acts as "reference implementation"? If that is the intention, 
then perhaps this could be used as commit message:

  remote-testgit: make use of the 'done' feature

  This might be helpful for people who would like to see how to properly
  implement the "done" feature.

But again, I am not sure if I understood the purpose of this patch correctly. 
So please forgive me if this was totally off-base :-(.

Cheers,
Max

> 
> Signed-off-by: Felipe Contreras <felipe.contre...@gmail.com>
> ---
> git-remote-testgit | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/git-remote-testgit b/git-remote-testgit
> index 698effc..812321e 100755
> --- a/git-remote-testgit
> +++ b/git-remote-testgit
> @@ -55,8 +55,10 @@ while read line; do
> 
>               echo "feature import-marks=$gitmarks"
>               echo "feature export-marks=$gitmarks"
> -             git fast-export --use-done-feature 
> --{import,export}-marks="$testgitmarks" $refs | \
> +             echo "feature done"
> +             git fast-export --{import,export}-marks="$testgitmarks" $refs | 
> \
>                       sed -e "s#refs/heads/#${prefix}/heads/#g"
> +             echo "done"
>               ;;
>       export)
>               before=$(git for-each-ref --format='%(refname) %(objectname)')
> -- 
> 1.8.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to