On Wed, Apr 5, 2017 at 6:39 PM, Daniel Ferreira <bnm...@gmail.com> wrote:
> +int cmd_main(int argc, const char **argv) { Style (minor nit, in case resend is needed): We only put the { brace on the same line for statements (if, for, while, switch), not for function declarations. I tried to find a good rationale for it, this is the most sufficient I could find https://www.kernel.org/doc/Documentation/process/coding-style.rst (section 3): Heretic people all over the world have claimed that this inconsistency is ... well ... inconsistent, but all right-thinking people know that (a) K&R are **right** and (b) K&R are right. Besides, functions are special anyway (you can't nest them in C).