When we see an error from split_cmdline(), we exit the function without freeing the copy of the command string we made.
This was sort-of introduced by 22e5ae5c8 (connect.c: handle errors from split_cmdline, 2017-04-10). The leak existed before that, but before that commit fixed the bug, we could never trigger this else clause in the first place. Signed-off-by: Jeff King <p...@peff.net> --- This was meant to be part of the original patch in: http://public-inbox.org/git/20170411003554.2tjnn65vfco37...@sigill.intra.peff.net/ but I posted two versions in quick succession and Junio picked up the first one. :) connect.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/connect.c b/connect.c index 568a35f75..cd21a1b6f 100644 --- a/connect.c +++ b/connect.c @@ -738,8 +738,10 @@ static void handle_ssh_variant(const char *ssh_command, int is_cmdline, * any longer. */ free(ssh_argv); - } else + } else { + free(p); return; + } } if (!strcasecmp(variant, "plink") || -- 2.13.0.rc0.363.g8726c260e
