On Fri, Apr 28, 2017 at 1:59 AM, Ævar Arnfjörð Bjarmason
<ava...@gmail.com> wrote:
> On Fri, Apr 28, 2017 at 12:13 AM, Brandon Williams <bmw...@google.com> wrote:
>> On 04/27, Stefan Beller wrote:
>>> On Wed, Apr 26, 2017 at 4:12 PM, Ævar Arnfjörð Bjarmason
>>> <ava...@gmail.com> wrote:
>>> > Rename the t5614-clone-submodules.sh test to
>>> > t5614-clone-submodules-shallow.sh. It's not a general test of
>>> > submodules, but of shallow cloning in relation to submodules. Move it
>>> > to create another similar t56*-clone-submodules-*.sh test.
>>> >
>>> > Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com>
>>> > ---
>>> > t/{t5614-clone-submodules.sh => t5614-clone-submodules-shallow.sh} | 0
>>> > 1 file changed, 0 insertions(+), 0 deletions(-)
>>> > rename t/{t5614-clone-submodules.sh =>
>>> > t5614-clone-submodules-shallow.sh} (100%)
>>> >
>>> > diff --git a/t/t5614-clone-submodules.sh
>>> > b/t/t5614-clone-submodules-shallow.sh
>>> > similarity index 100%
>>> > rename from t/t5614-clone-submodules.sh
>>> > rename to t/t5614-clone-submodules-shallow.sh
>>>
>>> Thanks for formatting the patches with rename detection. :)
>>> The rename looks good.
>>
>> Do you have to turn that on or is that on by default?
>
> Looks like it just uses the diff.renames setting which I don't tweak,
> I didn't do anything special, but maybe it picked up some part of my
> .gitconfig that doesn't look like it has anything to do with
> renames...
After reading the man page of format-patch, I do not think you'd need
to configure anything special as the default settings easily pickup
a rename with 100% similarity. It is only hairy when changes are in
there as well, then you may want to play around with -B/-M.
Thanks,
Stefan
