[PATCH 03/24] cache.h: drop read_cache_from

[Stefan Beller]

coccinelle patch:
@@ expression E; @@
-read_cache_from(E)
+read_index_from(&the_index, E)

additionally drop the define from cache.h manually

Signed-off-by: Stefan Beller <sbel...@google.com>
---
 apply.c          | 2 +-
 builtin/am.c     | 4 ++--
 builtin/commit.c | 6 +++---
 cache.h          | 1 -
 4 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/apply.c b/apply.c
index ae1b659b68..159e039a18 100644
--- a/apply.c
+++ b/apply.c
@@ -3985,7 +3985,7 @@ static int check_patch_list(struct apply_state *state, 
struct patch *patch)
 static int read_apply_cache(struct apply_state *state)
 {
        if (state->index_file)
-               return read_cache_from(state->index_file);
+               return read_index_from(&the_index, state->index_file);
        else
                return read_index(&the_index);
 }
diff --git a/builtin/am.c b/builtin/am.c
index c6a679d8e1..cb3e4dff63 100644
--- a/builtin/am.c
+++ b/builtin/am.c
@@ -1557,7 +1557,7 @@ static int run_apply(const struct am_state *state, const 
char *index_file)
        if (index_file) {
                /* Reload index as apply_all_patches() will have modified it. */
                discard_cache();
-               read_cache_from(index_file);
+               read_index_from(&the_index, index_file);
        }
 
        return 0;
@@ -1600,7 +1600,7 @@ static int fall_back_threeway(const struct am_state 
*state, const char *index_pa
                return error("could not build fake ancestor");
 
        discard_cache();
-       read_cache_from(index_path);
+       read_index_from(&the_index, index_path);
 
        if (write_index_as_tree(orig_tree.hash, &the_index, index_path, 0, 
NULL))
                return error(_("Repository lacks necessary blobs to fall back 
on 3-way merge."));
diff --git a/builtin/commit.c b/builtin/commit.c
index 01d298c836..65a04ac199 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -370,7 +370,7 @@ static const char *prepare_index(int argc, const char 
**argv, const char *prefix
                        unsetenv(INDEX_ENVIRONMENT);
 
                discard_cache();
-               read_cache_from(get_lock_file_path(&index_lock));
+               read_index_from(&the_index, get_lock_file_path(&index_lock));
                if (update_main_cache_tree(WRITE_TREE_SILENT) == 0) {
                        if (reopen_lock_file(&index_lock) < 0)
                                die(_("unable to write index file"));
@@ -489,7 +489,7 @@ static const char *prepare_index(int argc, const char 
**argv, const char *prefix
 
        discard_cache();
        ret = get_lock_file_path(&false_lock);
-       read_cache_from(ret);
+       read_index_from(&the_index, ret);
        return ret;
 }
 
@@ -949,7 +949,7 @@ static int prepare_to_commit(const char *index_file, const 
char *prefix,
         * the editor and after we invoke run_status above.
         */
        discard_cache();
-       read_cache_from(index_file);
+       read_index_from(&the_index, index_file);
        if (update_main_cache_tree(0)) {
                error(_("Error building trees"));
                return 0;
diff --git a/cache.h b/cache.h
index 4e913d1346..6abf48dcc3 100644
--- a/cache.h
+++ b/cache.h
@@ -354,7 +354,6 @@ extern void free_name_hash(struct index_state *istate);
 
 
 #ifndef NO_THE_INDEX_COMPATIBILITY_MACROS
-#define read_cache_from(path) read_index_from(&the_index, (path))
 #define read_cache_preload(pathspec) read_index_preload(&the_index, (pathspec))
 #define is_cache_unborn() is_index_unborn(&the_index)
 #define read_cache_unmerged() read_index_unmerged(&the_index)
-- 
2.13.0.rc1.39.ga6db8bfa24