On Mon, May 01, 2017 at 04:24:23PM -0700, Jonathan Tan wrote: > On 04/30/2017 07:29 PM, brian m. carlson wrote: > > - if (line->len <= 42) > > + if (!line->len) > > return NULL; > > I would omit this check - parse_oid_hex already exits early if the first > character is NUL. (The existing code makes a bit more sense, in that it > avoids checking the first few characters if we already know a bit more about > the string.)
Okay, I can do that. > Looks fine, up to here. > > (Also, you requested extra-careful review for this patch, but this patch > seems mostly mechanical to me.) Because the rebase ended up moving around a lot of code in a way that I felt was risky. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204
signature.asc
Description: PGP signature
