On Mon, May 08, 2017 at 12:03:35PM -0400, Marc Branchaud wrote: > The only change from v3 is in 3/4, to expand t4061 to test various > combinations of --(no-)indent-heuristic and diff.indentHeuristic. > > I kindof went all-in and tried to cover every possible combination for > all four affected commands.
TBH, I don't know that we need to be that thorough. Unless we have a reason to believe that the code will behave differently in context A versus B, it's probably not buying us much. It would be nice, of course, if we could get full coverage of all possible paths through the program, but I think that involves a combinator explosion. But I'm OK with what you have here (the whole series, though I dropped one or two comments while reading it). -Peff
