Duy Nguyen <pclo...@gmail.com> writes: > On Sun, May 7, 2017 at 11:20 AM, Junio C Hamano <gits...@pobox.com> wrote: >> On Thu, May 4, 2017 at 2:45 PM, Junio C Hamano <gits...@pobox.com> wrote: >>> >>> Nguyễn Thái Ngọc Duy <pclo...@gmail.com> writes: >>> >>> > Changes since v1: >>> > >>> > - fopen_or_warn() and warn_on_fopen_errors() are introduced. The >>> > latter's name is probably not great... >>> > - A new patch (first one) to convert a bunch to using xfopen() >>> > - Fix test failure on Windows, found by Johannes Sixt >>> > - Fix the memory leak in log.c, found by Jeff >>> > >>> > There are still a couple of fopen() remained, but I'm getting slow >>> > again so let's get these in first and worry about the rest when >>> > somebody has time. >> >> Hmm, is this topic responsible for recent breakage Travis claims on MacOS X? >> >> https://travis-ci.org/git/git/jobs/229585098#L3091 >> >> seems to expect an error when test-config is fed a-directory but we are >> not getting the expected warning and error? > > Sounds about right. Let me see if defining FREAD_READS_DIRECTORIES on > MacOS X makes travis happy.
Thanks. I should have suspected that myself to save a round-trip.
