On 06/07, Johannes Schindelin wrote: > We are about to change the way aliases are expanded, to use the early > config machinery. > > This machinery reports errors in a slightly different manner than the > cached config machinery.
Not a comment on the patch but just a genuine question: Is there any reason why they complain in a different way? Doesn't it make sense for the errors to be reported consistently? > > Let's not get hung up by the precise wording of the message mentioning > the lin number. It is really sufficient to verify that all the relevant > information is given to the user. > > Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> > --- > t/t1308-config-set.sh | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh > index ff50960ccae..69a0aa56d6d 100755 > --- a/t/t1308-config-set.sh > +++ b/t/t1308-config-set.sh > @@ -215,7 +215,9 @@ test_expect_success 'check line errors for malformed > values' ' > br > EOF > test_expect_code 128 git br 2>result && > - test_i18ngrep "fatal: .*alias\.br.*\.git/config.*line 2" result > + test_i18ngrep "missing value for .alias\.br" result && > + test_i18ngrep "fatal: .*\.git/config" result && > + test_i18ngrep "fatal: .*line 2" result > ' > > test_expect_success 'error on modifying repo config without repo' ' > -- > 2.13.0.windows.1.460.g13f583bedb5 > > -- Brandon Williams
