On Sat, Jun 10, 2017 at 01:41:01PM +0200, SZEDER Gábor wrote: > rev_info.early_output started out as an unsigned int in cdcefbc97 (Add > "--early-output" log flag for interactive GUI use, 2007-11-03), but > later it was turned into a single bit in a bit field in cc243c3ce > (show: --ignore-missing, 2011-05-18) without explanation, though the > code using it still expects it to be a regular integer type and uses > it as a counter. Consequently, any even number given via > '--early-output=<N>', or indeed a plain '--early-output' defaulting to > 100 effectively disabled the feature. > > Turn rev_info.early_output back into its origin unsigned int data > type, making '--early-output' work again. > > Signed-off-by: SZEDER Gábor <szeder....@gmail.com> > --- > > > But the "users still expect" bit was a bit subtle to me, as I thought > > you meant users of Git. But you mean that the feature itself is not a > > boolean, but rather an integer count of how much early output to show. > > Yeah, I wrote "callsites" first, but then realized it's not a > function... > > Here is the same patch with an updated commit message now saying "code > using it" and "used as a counter" to make it clearer. It also > mentions that an argumentless '--early-output' turns off the feature, > too. > > I won't resend the rest of the series.
Thanks, this version is much more clear. -Peff
